feat: push IN predicate down to Lance filter engine#21
Open
wombatu-kun wants to merge 1 commit into
Open
Conversation
wombatu-kun
force-pushed
the
feature/in-pushdown
branch
from
9eac2c7 to
714f3b6
Compare
Render `field IN (v1, v2, ...)` from Flink's IN CallExpression using the existing literal-escaping helper, and expose getFilters() so tests can assert the exact Lance SQL string. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
wombatu-kun
force-pushed
the
feature/in-pushdown
branch
from
714f3b6 to
5901c26
Compare
Author
|
This PR doubles as a fix for a pre-existing failure on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LanceDynamicTableSource(previously returned null, forcing Flink to evaluate IN in-process).getFilters()so tests can verify the rendered Lance SQL.Test plan
mvn test— 178/178 passing (17 skipped = MinIO integration gate, no env vars).LanceReadOptimizationsTest#testInPredicatePushDownnow asserts both acceptance and the exact stringstatus IN ('active', 'pending', 'completed').🤖 Generated with Claude Code